Skip to content

fix(input): debounce is set with binding syntax in angular on load - #29377

Merged
sean-perkins merged 1 commit into
mainfrom
sp/FW-6198
Apr 23, 2024
Merged

fix(input): debounce is set with binding syntax in angular on load#29377
sean-perkins merged 1 commit into
mainfrom
sp/FW-6198

Conversation

@sean-perkins

Copy link
Copy Markdown
Contributor

Issue number: resolves #29374


What is the current behavior?

When using Angular binding syntax, the debounce value can be set after connectedCallback, but before componentDidLoad. This results in the internal representation of the debounce value to be the default and the watch callback to never fire.

What is the new behavior?

  • The callback handler for debounce is called on component load, identical to what we do for the same exact reasons for the input type.
  • debounce will correctly reflect and apply the developers value when using binding syntax on initial load

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 8.0.1-dev.11713879639.102f51a0

Forked reproduction with the dev-build is available here: #29374 (comment)

@vercel

vercel Bot commented Apr 23, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview Apr 23, 2024 1:53pm

@github-actions github-actions Bot added the package: core @ionic/core package label Apr 23, 2024
@sean-perkins
sean-perkins marked this pull request as ready for review April 23, 2024 15:35
@sean-perkins
sean-perkins requested a review from a team as a code owner April 23, 2024 15:35
@sean-perkins
sean-perkins requested a review from thetaPC April 23, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ion-input debounce is not set with binding syntax on initial load

2 participants